applied: https://github.com/crash-utility/crash/commit/9495fa7c1a38f4547e2142228f08b4146673062b
On Tue, Sep 16, 2025 at 9:14 AM Tao Liu <[email protected]> wrote: > > Hi Lianbo, > > LGTM, so ack. > > Thanks, > Tao Liu > > On Mon, Sep 15, 2025 at 9:38 PM Lianbo Jiang <[email protected]> wrote: > > > > The current issue occured on gcc version 8.5.0, can not been > > seen in the latest gcc version. > > > > $ make -j8 lzo > > symbols.c: In function ‘namespace_ctl’: > > symbols.c:3358:3: error: a label can only be part of a statement and a > > declaration is not a statement > > char demangled[BUFSIZE] = {0}; > > ^~~~ > > make[5]: *** [Makefile:403: symbols.o] Error 1 > > make[5]: *** Waiting for unfinished jobs.... > > ... > > crash build failed > > ... > > > > Let's put the declaration at the beginning of this function to > > fix such cases. > > > > Reported-by: Tao Liu <[email protected]> > > Signed-off-by: Lianbo Jiang <[email protected]> > > --- > > symbols.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/symbols.c b/symbols.c > > index f9eb51f6cd63..112bcc630bf2 100644 > > --- a/symbols.c > > +++ b/symbols.c > > @@ -3325,6 +3325,7 @@ namespace_ctl(int cmd, struct symbol_namespace *ns, > > void *nsarg1, void *nsarg2) > > char *name; > > long cnt; > > int len; > > + char demangled[BUFSIZE] = {0}; > > > > switch (cmd) > > { > > @@ -3355,7 +3356,6 @@ namespace_ctl(int cmd, struct symbol_namespace *ns, > > void *nsarg1, void *nsarg2) > > return TRUE; > > > > case NAMESPACE_INSTALL: > > - char demangled[BUFSIZE] = {0}; > > sp = (struct syment *)nsarg1; > > name = (char *)nsarg2; > > len = strlen(name)+1; > > -- > > 2.50.1 > > -- > > Crash-utility mailing list -- [email protected] > > To unsubscribe send an email to [email protected] > > https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ > > Contribution Guidelines: https://github.com/crash-utility/crash/wiki -- Crash-utility mailing list -- [email protected] To unsubscribe send an email to [email protected] https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
