In my opinion the proposal needs to be amended in the following ways:

Scope:

Understanding the scope of this Change requires understanding how many
programs there are that will have to be adapted to avoid getting killed.
Therefore the Scope section should contain a complete list of affected
packages. It would also be good to list known affected programs that
aren't packaged in Fedora, as users may be using them.

Currently not even all of the programs that were mentioned in the first
email thread are listed. I suspect that there are more, maybe many more.


How To Test:

This section says only: "User processes should be terminated when a user
session ends. Services which take the steps to stay around should stay
around."

That's how things have always been *supposed* to work. To verify that
KillUserProcesses actually works, a tester needs a program that is
supposed to terminate with the user session, but doesn't, so that they
can check that SystemD kills the program successfully.


Contingency Plan:

It should be stated under what circumstances the contingency plan will
be activated. If KillUserProcesses itself works as intended, but none
of the affected programs have been adapted to not break, will Fedora 25
then be released with these programs broken, or will KillUserProcesses
be changed back to "no"? What if only half of the affected programs
have been adapted? Or all but one of them?


Release Notes:

Sysadmins need to be made aware that any in-house-written or otherwise
locally installed persistent programs they might have will stop working,
so a release note is quite important.


Björn Persson

Attachment: pgpxon9aB9w1o.pgp
Description: OpenPGP digital signatur

--
devel mailing list
devel@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Reply via email to