On 19/03/17 03:33 +0000, Tomasz Kłoczko wrote:
Started cleaning parted.spec and found method *much* more often used.

[tkloczko@domek SPECS.fedora]$ grep CFLAGS * | grep -- -Wno
alex4.spec:  CFLAGS="$RPM_OPT_FLAGS *-Wno*-deprecated-declarations"

There's nothing wrong with this option. Many C++ packages want to
support building with a C++98 compiler, so they use std::auto_ptr.
That gives warnings when built with a modern GCC using default
settings. Disabling the warning is reasonable.

xscreensaver.spec:export CFLAGS="$CFLAGS *-Wno*-long-long"
xscreensaver.spec:export CFLAGS="$CFLAGS *-Wno*-variadic-macros"

These are harmless to disable, but also redundant. Fedora's GCC
defaults to C11 which supports long long and variadic macros, so won't
warn about them anyway.

Not everything in your report is a problem. Automatically emailing
somebody from upstream or refusing to allow those -Wno-* options in
spec files would not improve Fedora measurably.
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Reply via email to