On Jan 24, 2018 08:55, "Miroslav Suchý" <msu...@redhat.com> wrote:
Dne 20.1.2018 v 12:27 Igor Gnatenko napsal(a): > Why I'm writing this? I want to hear from you if you think it would be good to > prohibit (or advise, or whatever mechanism would work) usage if conditionals in > (at least) master branch to allow us to develop features faster. Thoughts? > Suggestions? I just stumbled on other counter example. In Copr you submit one SRPM and you want to have build in different chroots. This can be hardly done without conditionals. Yes, but not really, since you can always specify the chroots a specific package should be built in. However, this is what I do for my ~50 nightly builds packages in COPR: clean, condition-free spec files in official fedora branches, and a "combined" spec (with conditionals accounting for differences between fedora branches, if any) for nightly COPR builds - so the maintenance overhead is very low, and the chance für bugs is small, since the "combining" is trivial (copy-paste, usually) - but the canonical versions are if course always the conditional-free specs from fedora. I wouldn't want to use the "combined" spec there. In Copr we use spec generators (pyp2rpm, gem2spec). Now we generate one spec (and SRPM). If conditionals were prohibited, then we would need to generate several SRPMs and upstream of those tools will have to maintains several templates. Well, the good thing is, nobody cares (or can care, with the amount of packages built there) about Packaging Guidelines in COPR, so that point is moot anyway Fabio Miroslav _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
