On Thu, Feb 15, 2018 at 10:36 AM, Igor Gnatenko < ignatenkobr...@fedoraproject.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Thu, 2018-02-15 at 10:17 +0100, Michal Novotny wrote: > > I feel PRs are better for this sort of stuff. Mainly because people are > > informed why exactly this change is made, > > they can read the guidelines and then merge the change when they are sure > > they understand it. It helps spreading knowledge > > and keeping community involved. Python team did it very well in their > > "Fedora's > > Switch to Python 3 effort > > <https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3>", i > think. > > Python changes are needed to be carefully inspected while this thing is > about > removing **single line** which is not needed for **10 years**. Also > guidelines > for Python changed recently while BuildRoot tag is not needed for many > years > and everyone should be aware of that. > Also look what's the progress of python→python2. It's not close to complete > in > any way. Most of PRs are opened and no one looks into them. > As far as I know, they are going to auto-merge the PR after some period of time, which is probably a pretty good solution. > > > There are other reasons too. Some projects might keep the original spec > > file somewhere > > else than in DistGit and they need to port those changes back to the > > original spec files. It is much more pleasant to have those > > changes placed in a PR with a relevant description, which will also give > > them a proper notification. Otherwise, they might end > > up solving some unexpected conflicts next time they import their new spec > > files into DistGit. > > You probably not aware, but we have guidelines about exactly this thing[0]. > > Fedora's git repository is the canonical location for Fedora spec files. > Maintainers MUST expect that other maintainers and automated tooling will > make > changes to their packages, potentially without communicating prior to > doing so > (though communication is always encouraged). If some maintainers are also > attempting to keep copies of a spec in an outside repository, they MUST be > prepared to merge changes made to the spec in Fedora's repository, and > MUST NOT > overwrite those changes with a copy from an external repository or using > fedpkg > import. > I am overwriting changes in %changelog from auto-rebuilds all the time because I don't really want messages in %changelog like: "Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild"; I think that by PRs (that would get automatically merged after some time) more could be actually achieved in a long run. If you make a PR and you give it a good description, it will probably reach more people. But I admit it's more difficult to do than a single commit. > > > Maybe it would be nice if proven packagers had some tooling for doing > those > > changes. > > If you will develop one, we could talk about it 😉 > > [0] https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Mai > ntenance_and_Ca > nonicity > > > > clime > > > > On Thu, Feb 15, 2018 at 9:34 AM, Miroslav Suchý <msu...@redhat.com> > wrote: > > > > > Dne 14.2.2018 v 20:41 Igor Gnatenko napsal(a): > > > > On Wed, 2018-02-14 at 14:25 -0500, David Cantrell wrote: > > > > > On 02/14/2018 11:44 AM, Remi Collet wrote: > > > > > > - abuse proven packager privileges > > > > > > > > > > +1 > > > > > > +1 > > > > > > > Please, read policy[0] once more. > > > > > > > > > Sometimes there are situations where it's simply a lot easier to > fix > > > > > > stuff > > > > directly in Git than via bugzilla and the proper maintainers. So much > > > > > > easier > > > > that we should leave this path open. These situations shouldn't arise > > > > > > that > > > > often. Some examples of situations were bypassing the proper > maintained > > > > > > is > > > > considered fine: > > > > > […] > > > > > * small fixes or adjustments for new or modified packaging > > > > > > > > guidelines can be done directly in Git after being announced some > days > > > > in advance. > > > > > > > > I just missed waiting for few days (kinda intentionally), because it > > > > > > would not > > > > help anyone and will just disturb maintainers to do the actual work > > > > > > whereas it > > > > doesn't make any sense because cleanup is automated. > > > > > > It state: > > > fixes or adjustments for **new or modified** packaging guidelines > > > > > > This is obviously meant for changes, which would block progress. > Change of > > > BuildRoot tag is pretty old. It could wait > > > few more days just fine. > > > > > > > > > Miroslav > > > > > > > > > _______________________________________________ > > > devel mailing list -- devel@lists.fedoraproject.org > > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > > > > > > > > > _______________________________________________ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > - -- > - -Igor Gnatenko > -----BEGIN PGP SIGNATURE----- > > iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlqFVJMACgkQaVcUvRu8 > X0zFxBAAgT91bOniQKMtoWJua4CcEL8jIsyegzER0i4/as/8nahnzHDZkPYtkaEA > 89Jtd+RyMacyZ0Pg2Bj/hRuyJWohYp/tDxJP+oP2M36oHrbDr4oyGxGg08f60x3z > SX6RwVtrdBwYPiIczDoOgcxNdE7FuIFRl+KXyvTVAdy8XeLniwZBLN5pRvHp9MMg > f2rzf3Wxz3R61DewegT3/UdQ0CDo30zf2PvWZtQhWBOu99JQqLqbKLBoH/42A1VC > tyRkfpwqMSG6vPzIPjQvDoLyjhF0j51hnYRahoigM3+PFOazHmI4+RCpW2FpUWcB > MLtfWIMaFv3GjQx4WIoDef9Nl7y/2gMLQf7HUCeXYyjc8rGC24RKG9Zkpi3tT5ks > xppLmHQEdpuJWcSN6OknEQAmo+UDeoPtHSCrJFqQngTxCQ72sfFQIcRwHXBO0tTN > y6AJ8kZw91gmQfwIy2e1tf5CXTlfwlIUAWKUEwT24hmLfF8LiOPn6qukrziqB/y4 > 573cskxhfPumD4JAz95F8aCQheBUaBuXTgTAcL4ZwJi/Xu1v+J1Sip2Nr1GWl891 > iVtGMeNlBszJUYdahR/Fg4Ed7mKm/q5o3bifbGVzur6r7reLTozzg0OsxNTXjI9h > h1Pa9zGTWYWF5vXP+KWvZi1BKZoaObSXjpVtuubdBjN/J7SGn1M= > =Ejay > -----END PGP SIGNATURE----- > >
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
