https://bugzilla.redhat.com/show_bug.cgi?id=1738293
How did it pass review?
> Obsoletes: compton
Silently doing Obsoletes of an active package and doing so even
without version which is prohibited by the Packaging Guidelines.
Really?
> cp -a yshui-%{appname}-%{test_shortcommit}/subprojects/test.h
> /builddir/build/BUILD/%{appname}-%{version}/subprojects/
I am not sure if it is written anywhere, but hardcoding
/builddir/whatsoever is so bad…
> %meson --buildtype=release
There is specific reason why we have --buildtype=plain in %meson
macro, because with release buildtype, debuginfo is unusable…
> # Enable LTO
> %global optflags %{optflags} -flto=$(nproc)
> %global build_ldflags %{build_ldflags} -flto
Have anybody ever talked to the RPM folks about proper way of enabling
LTO for builds? This specific way of setting it makes build
non-reproducible.
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
