On 06/20/2020 11:14 AM, Zbigniew Jędrzejewski-Szmek wrote:
> On Fri, Jun 19, 2020 at 05:11:43PM -0400, Ben Cotton wrote:
>> The %make_build macro enables parallel make builds using the -j option.  In
>> case a package does not build correctly with parallel make, then parallel
>> make will be disabled for that package by redefining the %_smp_mflags macro
>> like this:
>>
>>   %global _smp_mflags -j1
> 
> That is rather unwiely, in particular because it's quite common for
> just *some* make invocations to fail in parallel mode. (E.g. the main
> build works, but doc build fails, or install, etc.)
> 
> Why not specify the override for the individual invocation:
> %make_build -j1
> %make_install -j1
> %make_build -C docs -j1
> 

I agree, this would be better.  I am going to update the proposal to
include this.

-Tom

> Zbyszek
> _______________________________________________
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> 
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to