On 14. 06. 21 17:52, Vitaly Zaitsev via devel wrote:
On 14.06.2021 15:32, Ben Cotton wrote:
Running upstream tests is mandatory.

What about tests that require network access?

From the proposed guidelines:

If a test suite exists upstream, it MUST be run in the %check section and/or
in Fedora CI. You MAY exclude specific failing tests.

You MUST NOT disable the entire testsuite or ignore the result to solve a
build failure.

As an exception, you MAY disable tests with an appropriate %if conditional
(e.g. bcond) when bootstrapping.


Assuming that *all the tests* require network access, you should run them on Fedora CI instead.

Assuming only some of the tests require network access, you should exclude them in %check (and possibly run them on Fedora CI instead).

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to