------- Original Message ------- On Tuesday, August 9th, 2022 at 1:31 PM, Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Tue, Aug 09, 2022 at 04:51:03PM +0000, Gwyn Ciesla via devel wrote: > > > Good morning! > > > > zfs-fuse is FTBFS starting with f36. > > > > https://bugzilla.redhat.com/show_bug.cgi?id=2047144 > > > > I've been banging my head on it for a long time, to no avail. I can get > > around the SConstruct failure by removing some environment variables, and > > then I hit a linking issue I can't get past. > > > Most problems are caused by GCC 10 no longer merging duplicate global > variable storage. This was super tedios to resolve. I started with > the gcc10_fixes.patch from Debian and had to tweak it even more. > > A build system bug was causing the extra quotes in compiler options. > > The code is broken wrt -Wformat-security. So this has to be turned > off, unless someone wants to audit all the printf() calls and fix > them up. I'd recommend the latter really, but I attach the quick > fix since that is at least no more awful than it has been for every > Fedora release previously. > > So in the RPM spec add > > diff --git a/zfs-fuse.spec b/zfs-fuse.spec > index b26c656..84b6eb0 100644 > --- a/zfs-fuse.spec > +++ b/zfs-fuse.spec > @@ -17,6 +17,8 @@ Patch0: zfs-fuse-0.7.2.2-stack.patch > Patch1: zfs-fuse-0.7.2.2-python3.patch > Patch2: tirpc.patch > Patch3: common.patch > +Patch4: gcc.patch > + > BuildRequires: gcc > BuildRequires: fuse-devel libaio-devel perl-generators scons gcc-c++ > BuildRequires: zlib-devel openssl-devel libattr-devel lzo-devel bzip2-devel > xz-devel > @@ -50,6 +52,7 @@ operating system. > %patch1 -p1 > %patch2 -p1 > %patch3 -p0 > +%patch4 -p1 > > f=LICENSE > mv $f $f.iso88591 > @@ -63,6 +66,7 @@ chmod -x contrib/zfsstress.py > cp -f /usr/lib/rpm/redhat/config.{guess,sub} src/lib/libumem/ > > %build > +%define _warning_options '-Wall' > export CCFLAGS="%{optflags}" > pushd src > > > The gcc.patch is attached. > > > Only libguestfs and libvirt require this, other that users with > > ZFS filesystems, but I'd rather not retire it if it can be avoided. > > > Don't let libvirt/libguestfs force you to keep maintaining zfs-fuse. > > If you want to retire it, we'll just disable zfs in libvirt/libguestfs. > > Honestly I'd retire it, given it is dead upstream, unless someone > wants to re-incarnate the upstream project and bring the code upto > modern standards. Even with the patches there's still tonnes of > (non-fatal) compiler warnings that really ought to be evaluated > for correctness. That did the trick, thank you! I'd like to keep it around at least for awhile. I'm not sure it's worth that level of maintenance, at least by me, who doesn't use ZFS. It *is* worth quick fixes like this, IMHO. > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
signature.asc
Description: OpenPGP digital signature
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
