Miro Hrončok kirjoitti 6.10.2022 klo 2.33:
On 06. 10. 22 1:21, Otto Liljalaakso wrote:
Recently, I have run into some cases where file dependencies like
Requires: /usr/bin/foo are used.
In a recent thread on this mailing list [1],
it is mentioned that such Requires should be avoided,
because resolving file dependencies requires a large amount of memory.
I don't believe that resolving file-Requires from directories listed at
[2] from your email is more memory hungry. Where exactly was that said?
[1]:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CRREDQUPPJYWVRMA4DOKYU2KZZLKC4D5/
[2]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies
Maybe I should have re-read the thread closely before posting,
because the most relevant message is this [3]:
"
The discussion in the bug indicates that this memory growth is related to
loading of the full filepath dataset. We have been discussing splitting
out the non-primary-filepath-data (i.e. paths that are not /etc, /usr/bin,
/usr/sbin), out into a separate lazilly-loaded file. If we manage to do
that, we'll kill two birds with one stone:
- initial download of repo metadata on every freakin' dnf operation can
go down from 80 to 20 MB
- the peak memory use will go down
"
Which exactly confirms what you say.
I am still wondering a bit if there is something else bad about file
dependencies?
I was asked not to use those in a recent package review [4].
Maybe that was just a reviewer preference then,
and not based on any benefit for the distribution?
[3]:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/QOQQNVN4JPJOAVUBJJM4XLSINPTOG3VE/
[4]: https://bugzilla.redhat.com/show_bug.cgi?id=2115066
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
