On Tue, Dec 27, 2022 at 7:30 PM Ron Olson <tachokni...@gmail.com> wrote: > > Hey all- > > I commented out a SOURCES line in a spec file to test something and got an > interesting warning: “Macro expanded in comment on line …”. I assume it’s > just that, a warning, but was kinda surprised to see a commented-out line > being evaluated at all. I did some searching and came across this BZ from > 2015: https://bugzilla.redhat.com/show_bug.cgi?id=1224660 that seems to > suggest there’s a better way (%dnl), so if I want to comment something out > instead of putting a # in front of the line, I should use %dnl?
I think it should be fine in most cases, but I'm not sure what happens if the macro expands to multiple lines. Unless RPM does some magic trick and marks *all* lines from macros expanded inside a comment as comments, all but the first line of the expanded macro would end up being ... not comments. Fabio _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
