On Mon, Jul 24, 2023 at 09:47:32PM -0500, Michel Alexandre Salim wrote:
> Hi all,
> 
> On Mon, Jul 17, 2023 at 10:54:43AM -0600, Jerry James wrote:
> > Like many of you, I have been quite inconvenienced because of
> > dnf5-related breakage of fedora-review.  I've been monkeying with it
> > today and finally got a successful run of fedora-review after making
> > the following changes [*].
> >
> I'm happy (and relieved) to say that a fixed fedora-review is ready for
> testing:
> 
> https://bodhi.fedoraproject.org/updates/?search=&packages=fedora-review&status=pending&status=testing
> 
fedora-review-0.10.0-1.fc3{7,8} had shebang issues, for those who are
testing please retest fedora-review-0.10.0-2.fc3{7,8} that I just posted
to fix this, thanks!

Turns out we never touched the shebangs and they still had Python
2-isms, and %{py3_shebang_fix} just adds a duplicate -sP which is not
needed -- it's the -tt that was the issue.

-- 
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to