Ravindra Kumar (ravindraku...@vmware.com) said: 
> Please let me know when can I checkin this change.

Oops, my apologies. I got the OK from the translation list, so I checked
in the change already. Hope that's not a problem.

I added spice-vdagent and qemu-guest-agent where appropriate to the groups,
and I'll tweak the kickstart files that make the spins next.

Bill


> 
> Thanks,
> Ravindra
> 
> ----- Original Message -----
> From: "Bill Nottingham" <nott...@redhat.com>
> To: "Development discussions related to Fedora" 
> <devel@lists.fedoraproject.org>
> Cc: tr...@lists.fedoraproject.org
> Sent: Tuesday, May 14, 2013 12:51:45 PM
> Subject: Re: Adding new group to comps-f19.xml.in
> 
> Ravindra Kumar (ravindraku...@vmware.com) said: 
> > > The two added group are OK. grouplist is not something that actually is
> > > used, though; they would need to either be added as mandatory/optional
> > > groups to the desktop environments, or just brought in via the spins'
> > > kickstart files.
> > 
> > > Also, please attach patches - your  mailer appears to have mangled the
> > > spacing. 
> > 
> > Thanks Bill for looking at it. Could you please take a look at the new
> > patch (attached)?
> 
> Seems initially reasonable, might tweak the names/descriptions a bit
> (the names need to be distinct).
> 
> That being said, this would be a string freeze. CC'ing the translation
> list - OK to add these two groups to comps for F-19?
> 
> > I would appreciate if you could let me know a way to test comps file
> > changes.
> 
> Will follow up on devel@ only with this.
> 
> Bill
> 
> 
> > --- comps-f19.xml.in        2013-05-10 19:00:24.191468344 -0700
> > +++ comps-f19.xml.in.new    2013-05-12 21:49:31.433352612 -0700
> > @@ -5633,6 +5633,26 @@
> >      </packagelist>
> >    </group>
> >    <group>
> > +    <id>virt-agents</id>
> > +    <_name>Virtualization Agents</_name>
> > +    <_description>These packages enable better management of virtual 
> > machines.</_description>
> > +    <default>true</default>
> > +    <uservisible>true</uservisible>
> > +    <packagelist>
> > +      <packagereq type="default">open-vm-tools</packagereq>
> > +    </packagelist>
> > +  </group>
> > +  <group>
> > +    <id>virt-agents-x</id>
> > +    <_name>Virtualization Agents</_name>
> > +    <_description>These packages enable better user experience for virtual 
> > machines.</_description>
> > +    <default>true</default>
> > +    <uservisible>true</uservisible>
> > +    <packagelist>
> > +      <packagereq type="default">open-vm-tools-desktop</packagereq>
> > +    </packagelist>
> > +  </group>
> > +  <group>
> >      <id>virtualization</id>
> >      <_name>Virtualization</_name>
> >      <_description>These packages provide a virtualization 
> > environment.</_description>
> > @@ -5878,6 +5898,8 @@
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> >        <groupid>firefox</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>gnome-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -5902,6 +5924,8 @@
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>kde-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -5928,6 +5952,8 @@
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>xfce-desktop</groupid>
> >        <groupid>xfce-apps</groupid>
> >        <groupid>xfce-media</groupid>
> > @@ -5953,6 +5979,8 @@
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>lxde-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -5977,6 +6005,8 @@
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>cinnamon-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -5998,6 +6028,8 @@
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>printing</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>mate-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -6019,6 +6051,8 @@
> >        <groupid>input-methods</groupid>
> >        <groupid>multimedia</groupid>
> >        <groupid>hardware-support</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>sugar-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -6051,6 +6085,8 @@
> >        <groupid>gnome-software-development</groupid>
> >        <groupid>kde-software-development</groupid>
> >        <groupid>x-software-development</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>virtualization</groupid>
> >        <groupid>web-server</groupid>
> >      </grouplist>
> > @@ -6084,6 +6120,7 @@
> >        <groupid>standard</groupid>
> >        <groupid>core</groupid>
> >        <groupid>hardware-support</groupid>
> > +      <groupid>virt-agents</groupid>
> >        <groupid>web-server</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -6108,6 +6145,7 @@
> >        <groupid>standard</groupid>
> >        <groupid>core</groupid>
> >        <groupid>hardware-support</groupid>
> > +      <groupid>virt-agents</groupid>
> >      </grouplist>
> >      <optionlist>
> >        <groupid>dogtag</groupid>
> > @@ -6138,6 +6176,8 @@
> >        <groupid>fonts</groupid>
> >        <groupid>hardware-support</groupid>
> >        <groupid>multimedia</groupid>
> > +      <groupid>virt-agents</groupid>
> > +      <groupid>virt-agents-x</groupid>
> >        <groupid>basic-desktop</groupid>
> >      </grouplist>
> >      <optionlist>
> > @@ -6163,6 +6203,7 @@
> >      </grouplist>
> >      <optionlist>
> >        <groupid>standard</groupid>
> > +      <groupid>virt-agents</groupid>
> >      </optionlist>
> >    </environment>
> >    <category>
> 
> > -- 
> > devel mailing list
> > devel@lists.fedoraproject.org
> > https://admin.fedoraproject.org/mailman/listinfo/devel
> 
> -- 
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel

> --- comps-f19.xml.in  2013-05-17 16:10:43.159019943 -0700
> +++ comps-f19.xml.in.new2     2013-05-17 15:57:43.416019041 -0700
> @@ -5633,6 +5633,26 @@
>      </packagelist>
>    </group>
>    <group>
> +    <id>guest-agents</id>
> +    <_name>Guest Agents</_name>
> +    <_description>Agents used when running under a hypervisor.</_description>
> +    <default>true</default>
> +    <uservisible>true</uservisible>
> +    <packagelist>
> +      <packagereq type="default">open-vm-tools</packagereq>
> +    </packagelist>
> +  </group>
> +  <group>
> +    <id>guest-desktop-agents</id>
> +    <_name>Guest Desktop Agents</_name>
> +    <_description>Agents used when running as a virtualized 
> desktop.</_description>
> +    <default>true</default>
> +    <uservisible>true</uservisible>
> +    <packagelist>
> +      <packagereq type="default">open-vm-tools-desktop</packagereq>
> +    </packagelist>
> +  </group>
> +  <group>
>      <id>virtualization</id>
>      <_name>Virtualization</_name>
>      <_description>These packages provide a virtualization 
> environment.</_description>
> @@ -5878,6 +5898,8 @@
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
>        <groupid>firefox</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>gnome-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5902,6 +5924,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>kde-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5928,6 +5952,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>xfce-desktop</groupid>
>        <groupid>xfce-apps</groupid>
>        <groupid>xfce-media</groupid>
> @@ -5953,6 +5979,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>lxde-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5977,6 +6005,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>cinnamon-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5998,6 +6028,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>mate-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6019,6 +6051,8 @@
>        <groupid>input-methods</groupid>
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>sugar-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6051,6 +6085,8 @@
>        <groupid>gnome-software-development</groupid>
>        <groupid>kde-software-development</groupid>
>        <groupid>x-software-development</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>virtualization</groupid>
>        <groupid>web-server</groupid>
>      </grouplist>
> @@ -6084,6 +6120,7 @@
>        <groupid>standard</groupid>
>        <groupid>core</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
>        <groupid>web-server</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6108,6 +6145,7 @@
>        <groupid>standard</groupid>
>        <groupid>core</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
>      </grouplist>
>      <optionlist>
>        <groupid>dogtag</groupid>
> @@ -6138,6 +6176,8 @@
>        <groupid>fonts</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>multimedia</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>basic-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6163,6 +6203,7 @@
>      </grouplist>
>      <optionlist>
>        <groupid>standard</groupid>
> +      <groupid>guest-agents</groupid>
>      </optionlist>
>    </environment>
>    <category>

> --- comps-f20.xml.in  2013-05-17 16:10:43.166020179 -0700
> +++ comps-f20.xml.in.new2     2013-05-17 15:17:12.517899565 -0700
> @@ -5656,6 +5656,26 @@
>      </packagelist>
>    </group>
>    <group>
> +    <id>guest-agents</id>
> +    <_name>Guest Agents</_name>
> +    <_description>Agents used when running under a hypervisor.</_description>
> +    <default>true</default>
> +    <uservisible>true</uservisible>
> +    <packagelist>
> +      <packagereq type="default">open-vm-tools</packagereq>
> +    </packagelist>
> +  </group>
> +  <group>
> +    <id>guest-desktop-agents</id>
> +    <_name>Guest Desktop Agents</_name>
> +    <_description>Agents used when running as a virtualized 
> desktop.</_description>
> +    <default>true</default>
> +    <uservisible>true</uservisible>
> +    <packagelist>
> +      <packagereq type="default">open-vm-tools-desktop</packagereq>
> +    </packagelist>
> +  </group>
> +  <group>
>      <id>virtualization</id>
>      <_name>Virtualization</_name>
>      <_description>These packages provide a virtualization 
> environment.</_description>
> @@ -5901,6 +5921,8 @@
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
>        <groupid>firefox</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>gnome-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5925,6 +5947,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>kde-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -5951,6 +5975,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>xfce-desktop</groupid>
>        <groupid>xfce-apps</groupid>
>        <groupid>xfce-media</groupid>
> @@ -5976,6 +6002,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>lxde-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6000,6 +6028,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>cinnamon-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6022,6 +6052,8 @@
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>printing</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>mate-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6043,6 +6075,8 @@
>        <groupid>input-methods</groupid>
>        <groupid>multimedia</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>sugar-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6075,6 +6109,8 @@
>        <groupid>gnome-software-development</groupid>
>        <groupid>kde-software-development</groupid>
>        <groupid>x-software-development</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>virtualization</groupid>
>        <groupid>web-server</groupid>
>      </grouplist>
> @@ -6108,6 +6144,7 @@
>        <groupid>standard</groupid>
>        <groupid>core</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
>        <groupid>web-server</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6132,6 +6169,7 @@
>        <groupid>standard</groupid>
>        <groupid>core</groupid>
>        <groupid>hardware-support</groupid>
> +      <groupid>guest-agents</groupid>
>      </grouplist>
>      <optionlist>
>        <groupid>dogtag</groupid>
> @@ -6162,6 +6200,8 @@
>        <groupid>fonts</groupid>
>        <groupid>hardware-support</groupid>
>        <groupid>multimedia</groupid>
> +      <groupid>guest-agents</groupid>
> +      <groupid>guest-desktop-agents</groupid>
>        <groupid>basic-desktop</groupid>
>      </grouplist>
>      <optionlist>
> @@ -6187,6 +6227,7 @@
>      </grouplist>
>      <optionlist>
>        <groupid>standard</groupid>
> +      <groupid>guest-agents</groupid>
>      </optionlist>
>    </environment>
>    <category>

> -- 
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Reply via email to