On 2/28/14, 8:12 AM, Eric Sandeen wrote:

> However, I see that (at least my copy of) fsadm requires xfs_check,
> which has been deprecated upstream in favor of xfs_repair -n.
> xfs_check doesn't scale, and xfs_repair -n performs the same
> tasks.
> 
>> XFS_CHECK=xfs_check
> 
> so I guess I should file a bug on that.

Sorry, I should have checked upstream, I see that upstream handles
absence of xfs_check.

>           "xfs") if which "$XFS_CHECK" >"$NULL" 2>&1 ; then
>                         dry "$XFS_CHECK" "$VOLUME"
>                  else
>                         # Replacement for outdated xfs_check
>                         # FIXME: for small devices we need to force_geometry,
>                         # since we run in '-n' mode, it shouldn't be problem.
>                         # Think about better way....
>                         dry "$XFS_REPAIR" -n -o force_geometry "$VOLUME"
>                  fi ;;

TBH, I would just switch 100% to xfs_repair, rather than using
it as a fallback.   We can talk about this offline though.  :)

Thanks,
-Eric
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Reply via email to