On Sat, Jan 10, 2015 at 18:33:14 +0100,
 Michael Schwendt <mschwe...@gmail.com> wrote:

Deleting files in %install is considered cleaner by many, because it
ensures that a file is not found inside the %buildroot anymore and cannot
be included accidentally either. The drawback is obvious: There ought to
be a comment explaining why a file is deleted.

In this particular case some stuff gets added depending on whether or not the build process finds all of the fonts that are needed. I wanted this to fail during build if any were not found, rather than just removing any fonts that showed up to be installed. So that I could add needed buildrequires and requires right away rather than after a new build was out.

When I was testing things I was a bit confused as to why I wasn't seeing build failures when I expected them.

And the test worked great. At the end I forgot to add buildrequires for some some fonts (even though I did have the requires for them) and a build failure told me to fix it right away.
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Reply via email to