Hi,

I would like to propose that we have a policy where any commits that touches the Glade file, must either contain the file's contents after saving it through the Glade's UI or include a commit that follows it with the noisy diff produced by Glade. The problem is, we all keep hand-editing to avoid crappy diffs, but it gets more and more out of sync with Glade and makes it even worse for the next guy.

Even right now it's impossible to make a change using Glade without breaking our custom icons that were added by hand[1] and Glade doesn't support writing their icon-names[2]. If the person making the changes is also the one to save the noisy Glade XML diff - even if as a separate commit after the clean hand-edit - then at least it's their own problem right away when something breaks and not left for the next sucker down the road who has non-trivial changes to make using Glade GUI :)

Or do we just want to abandon Glade and stick to hand-editing the 10,000 line GtkBuilder XML file?

P.S. Are we all still agreed to using old 3.8.1 version of Glade? I think this idea of using same version sounds good, at least we won't be causing additional noise in diffs due to different versions writing stuff out in different ways.

Thoughts?

Cheers,
Matthew Brush

[1] https://github.com/geany/geany/commit/dabae1f94f13a85b672746aa0a177d3534048d9f#L1R6
[2] https://bugzilla.gnome.org/show_bug.cgi?id=700652
_______________________________________________
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel

Reply via email to