Am 10.10.2013 03:43, schrieb Matthew Brush:
On 13-10-09 01:01 PM, Dimitar Zhekov wrote:
Hi, all,
I want to discuss how our FiF works, why, and possible improvements.
1. The FiF dialog is created programatically. Is there any reason for
that, or simply nobody cared to XML-ize it? I'm not aware of anything
that can be done gtk+ calls, but can't be done by loading a XML and
less gtk+ calls.
Proposition: move the presentation to glade as much as possible, and
fill the content with code, as in any normal program.
I have done this before in a branch, but just the Glade part, which
AFAIK is basically unmergable now because of volatility of Glade XML
file. What I did was I made one single Search dialog in Glade that
always showed the widgets that are in common between the various
search dialogs (find, replace, fif), and then the specific options for
the search type were each in their own container widget so they could
be hidden/shown depending on which search dialog needs to be shown.
There's some extra code to setup the dialog to be shown/work for the
correct search type but it probably dwarfs the amount of code removed
by putting all of them in the Glade file into a single DRY dialog.
I agree with the idea of moving it into glade files where it's more
easily hackable. Try my patched glate from [1]. It should solve the
volatile XML output.
Best regards.
_______________________________________________
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
