Hi everyone,
I don't use my Windows VM very often, but I realized today that the
completion popups were broken there during the 1.25 cycle [1].
Could everyone using a development version of Geany under Windows tell
me whether it works for them or not, and their Windows and GTK versions?
I myself tried on XP SP3 with GTK 2.24.10.
I found a way to fix the issue, and although it doesn't make any sense,
it seem to fix it reliably. Unfortunately it has a small side effect
that completion popup will have a minimal height that might be taller
than necessary when there is only one item in the list. But this
cosmetic detail is probably less problematic than a blank popup, right? :)
But I'd like to know if the problem happens to everyone or not, and
whether the attached patch fixes the problem for everyone with the issue.
Thanks in advance!
Colomban
[1]
http://git.geany.org/geany/commit/?id=4d66bd3745eb3759539b116e7784d11d035ebd44
diff --git a/scintilla/gtk/PlatGTK.cxx b/scintilla/gtk/PlatGTK.cxx
index 1445ac1..b307f12 100644
--- a/scintilla/gtk/PlatGTK.cxx
+++ b/scintilla/gtk/PlatGTK.cxx
@@ -1510,6 +1510,14 @@ static void small_scroller_class_init(SmallScrollerClass *klass) {
static void small_scroller_init(SmallScroller *){}
+#ifdef G_OS_WIN32
+// for some reason having a custom ScrolledWindow (even without any overrides) result
+// in blank popups on Windows (XP+GTK2 at least). So, as the popup's content is more
+// important than the small sizing benefit (it only allow for smaller minimal sizes),
+// make it a real no-op on Windows.
+# define small_scroller_get_type() GTK_TYPE_SCROLLED_WINDOW
+#endif
+
static gboolean ButtonPress(GtkWidget *, GdkEventButton* ev, gpointer p) {
try {
ListBoxX* lb = reinterpret_cast<ListBoxX*>(p);
_______________________________________________
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel
