On 17/04/15 21:32, Colomban Wendling wrote: > Le 12/04/2015 22:54, Enrico Tröger a écrit : >> Branch: refs/heads/master >> Author: Enrico Tröger <enrico.troe...@uvena.de> >> Committer: Enrico Tröger <enrico.troe...@uvena.de> >> Date: Sun, 12 Apr 2015 20:54:16 UTC >> Commit: f03206744361baac1c811db97f5d2816409d7787 >> >> https://github.com/geany/geany/commit/f03206744361baac1c811db97f5d2816409d7787 >> >> Log Message: >> ----------- >> Windows: Compile geany_private.rc into Geany.exe for version data and icon > > Should we integrate geany_private.rc in the library too? This isn't > done with Autotools, but could be added.
It's not really necessary. For Waf, I just added it to the binary where it is necessary and kept it for the library. The rc file serves two main purposes: - add the icon to the binary - add versioning information to the binary (e.g. in the file properties dialog in the Details tab) While especially the icon is important for the binary, I guess the rc file is just nice to have for the library but not necessary. But I agree we should do the same for Waf and autotools, either link it or don't link it. I don't mind which way to go. > Though, `waf build -v` warns that geany_private.rc.o is created more > than once (doesn't seem to be a real problem though). Noticed this too but yeah, I think too this isn't a big problem. Ideally Waf should detect that it built the file already for another target and just use the built object. Regards, Enrico -- Get my GPG key from http://www.uvena.de/pub.asc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
