On 2015-07-07 01:44 AM, Thomas Martitz wrote:
-------- Weitergeleitete Nachricht -------- Betreff: Re: Github loses comments Datum: Tue, 07 Jul 2015 00:29:38 -0700 Von: Ivan Žužak <supp...@github.com> An: Thomas Martitz <ku...@rockbox.org> Hi Thomas, Thanks for sharing those details about your workflow. If you create a comment on a commit which is a part of a pull request, and later on blow away that commit from the pull request with a rebase + force-push combo -- then that commit is no longer a part of the pull request so the comments are no longer shown inline on the pull request page.
Sadly, makes sense.
However, if you create comments on the pull request's diff itself -- then those comments are tied to the pull request. After you update a pull request (even with a rebase), those comments will still be around on the pull request page, but will be shown as "user commented on an outdated diff a day ago".
So does that mean it's ok to make comments either on the main page of the pull request or the "files changed" view which shows the combined changes?
Cheers, Matthew Brush _______________________________________________ Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
