On Tue, 25 Sep 2007 11:50:47 -0400
Bernardo Innocenti <[EMAIL PROTECTED]> wrote:
> Andres Salomon wrote:
>
> >> On the GX, we *save* them always and restore them only on powerup.
> >> Saving the registers is needed because, later on, we peek a few values
> >> from that structure for powering up the video unit.
> >
> > Er, brain fart. We don't want to be calling lx_graphics_{en,dis}able when
> > transitioning to state 2; that shuts down too many things. That's what
> > I meant to say.
>
> Then we'd be doing nothing at all in state 2! We'd be better off *not*
> calling the fb_power hook from fbmem.c in the first place.
No, we need to only be running part of lx_graphics_{en,dis}able, not the
entire thing.
>
> I thought all that was meant to save power when DCON is frozen. Otherwise,
> ajax's patch for freezing DCON would be pretty pointless, wouldn't it?
>
> Btw, I feel this patch would also fix the funny artifacts we observed when
> we applied ajax's patch for X11. What do you think?
>
Ooh, that would be a nice perk. Please do retest Ajax's patch when this
kernel bug is fixed.
_______________________________________________
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel
