On Mon, Jun 30, 2008 at 04:58:33PM -0400, C. Scott Ananian wrote:

> +                     yum -yt --nogpgcheck install $pkgs

1. As an earlier commenter hinted, you want localinstall because
   otherwise yum may try to talk to the network in order to download its
   header cache and to look for newer versions of packages that satisfy
   dependencies of the installation set.

> @@ -212,6 +228,11 @@ __EOF__
>               echo "olpc-configure: replaying rainbow spool..."
>               /usr/sbin/rainbow-replay-spool
>       fi
> +
> +     # developer customizations.
> +     if /usr/bin/olpc-test-devkey -q ; then
> +             install_customization_packages

2. Do we need a guard for the existence and executability of
   olpc-test-devkey?

3. Why do we care whether there's a devkey? We would actually be better
   off checking that all the RPMs we're installing are owned by uid 0,
   this being the exact privilege that we're attempting to safeguard. 

Michael
_______________________________________________
Devel mailing list
Devel@lists.laptop.org
http://lists.laptop.org/listinfo/devel

Reply via email to