The function is never called with NULL argument. Remove the check and refactor the rest including the debug statement.
Signed-off-by: Peter Krempa <[email protected]> --- src/util/virpcivpd.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/util/virpcivpd.c b/src/util/virpcivpd.c index 248a9b2790..81c7c317b3 100644 --- a/src/util/virpcivpd.c +++ b/src/util/virpcivpd.c @@ -175,23 +175,18 @@ virPCIVPDResourceGetFieldValueFormat(const char *keyword) bool virPCIVPDResourceIsValidTextValue(const char *value) { - size_t i = 0; + const char *v; + bool ret = true; - if (value == NULL) - return false; - - /* An empty string is a valid value. */ - if (STREQ(value, "")) - return true; - - while (i < strlen(value)) { - if (!g_ascii_isprint(value[i])) { - VIR_DEBUG("The provided value contains non-ASCII printable characters: %s", value); - return false; + for (v = value; *v; v++) { + if (!g_ascii_isprint(*v)) { + ret = false; + break; } - ++i; } - return true; + + VIR_DEBUG("val='%s' ret='%d'", value, ret); + return ret; } void -- 2.43.0 _______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
