On Fri, Apr 12, 2024 at 03:36 PM +0200, Marc Hartmayer <mhart...@linux.ibm.com> 
wrote:
> From: Boris Fiuczynski <fiu...@linux.ibm.com>
>
> Two situations will trigger an udev add event:
>  1) the mdev is created when started (transient) or
>  2) the mdev was defined and is started
> In case 1 there is no node object existing and no config data is copied.
> In case 2 copying the active config data of an existing node object will
> only copy invalid data. Instead copying the defined config data will
> store valid data into the newly added node object.
>
> Signed-off-by: Boris Fiuczynski <fiu...@linux.ibm.com>
> Reviewed-by: Jonathon Jongsma <jjong...@redhat.com>
> Reviewed-by: Marc Hartmayer <mhart...@linux.ibm.com>

> Signed-off-by: Marc Hartmayer <mhart...@linux.ibm.com>

This s-o-b is there by accident, will remove it in the next version.

> ---
>  src/node_device/node_device_udev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/node_device/node_device_udev.c 
> b/src/node_device/node_device_udev.c
> index f1e402f8f7f6..4730a5b986ca 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -1572,7 +1572,7 @@ udevAddOneDevice(struct udev_device *device)
>          objdef = virNodeDeviceObjGetDef(obj);
>  
>          if (is_mdev)
> -            nodeDeviceDefCopyFromMdevctl(def, objdef, false);
> +            nodeDeviceDefCopyFromMdevctl(def, objdef, true);
>  
>          persistent = virNodeDeviceObjIsPersistent(obj);
>          autostart = virNodeDeviceObjIsAutostart(obj);
> -- 
> 2.34.1
> _______________________________________________
> Devel mailing list -- devel@lists.libvirt.org
> To unsubscribe send an email to devel-le...@lists.libvirt.org
-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org

Reply via email to