On Tue, May 07, 2024 at 02:37:05PM +0200, Michal Prívozník wrote: > On 5/7/24 12:11, Daniel P. Berrangé wrote: > > On Mon, May 06, 2024 at 10:43:05AM +0200, Michal Privoznik wrote: > >> It's now more than two years since Ubuntu 22.04 was released and > >> per our support policy, Ubuntu 20.04 (the previous major release) > >> is now not supported. Remove it from our CI testing. > >> > >> Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > >> --- > >> ci/buildenv/ubuntu-2004.sh | 103 -------------------------- > >> ci/containers/ubuntu-2004.Dockerfile | 107 --------------------------- > >> ci/gitlab/builds.yml | 28 ++----- > >> ci/gitlab/containers.yml | 21 ++---- > >> ci/manifest.yml | 8 -- > >> 5 files changed, 14 insertions(+), 253 deletions(-) > >> delete mode 100644 ci/buildenv/ubuntu-2004.sh > >> delete mode 100644 ci/containers/ubuntu-2004.Dockerfile > > > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > > > > > FYI, I'd really *not* splitting out the removal and addition into > > separate jobs. If you remove 20.04 and add 24.04 in the same > > commit, then git shows the rename and we get a tiny diff so we > > can see the interesting changes. > > Yeah, and that's how I've started. But then I realized I needed to bump > glib version and Ubuntu 20.04 doesn't have it, but without the bump > Ubuntu 24.04 build fails. But maybe Fedora and AlmaLinux can be done > this way.
I'd suggest just temporarily disabling -Werror warnings, or disabling UBSAN. That way you can * squash the forthcoming warning * update all the distros new/old in one go * update glib & re-enable the warning With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
