On Tue, Oct 29, 2024 at 11:21:27PM -0400, Laine Stump wrote: > This reverts commit 42ab0148dd11727f7e3fd31dce4485469af290d5. > > This patch was supposed to fix the checksum of dhcp response packets > by setting it to 0 (because having a non-0 but incorrect checksum was > causing the packets to be droppe on FreeBSD guests). > > Early testing was positive, but after the patch was pushed upstream > and more people could test it, it turned out that while it fixed the > dhcp checksum problem for virtio-net interfaces on FreeBSD and > OpenBSD, it also *broke* dhcp checksums for the e1000 emulated NIC on > *all* guests (but not e1000e). > > So we're reverting this fix and looking for something more universal > to be included in the next release. > > Signed-off-by: Laine Stump <[email protected]> > --- > src/network/network_nftables.c | 69 ------------------- > tests/networkxml2firewalldata/base.nftables | 14 ---- > .../forward-dev-linux.nftables | 16 ----- > .../isolated-linux.nftables | 16 ----- > .../nat-default-linux.nftables | 16 ----- > .../nat-ipv6-linux.nftables | 16 ----- > .../nat-ipv6-masquerade-linux.nftables | 16 ----- > .../nat-many-ips-linux.nftables | 16 ----- > .../nat-port-range-ipv6-linux.nftables | 16 ----- > .../nat-port-range-linux.nftables | 16 ----- > .../nat-tftp-linux.nftables | 16 ----- > .../route-default-linux.nftables | 16 ----- > 12 files changed, 243 deletions(-)
Reviewed-by: Andrea Bolognani <[email protected]> -- Andrea Bolognani / Red Hat / Virtualization
