On 9/9/25 8:05 AM, Ján Tomko via Devel wrote:
Ján Tomko (8):
qemu: passt: split out qemuPasstBuildCommand
tests: qemuxmlconftests: store suffix in testQemuInfo
tests: qemuxmlconftest: Introduce testQemuConfMarkUsed
export qemuVirtioFSBuildCommandLine
tests: qemuxmlconftest: test passt command line too
tests: qemuxmlconf: virtiofs: remove locking from the readonly test
case
tests: qemuxmlconftests: test virtiofsd command line too
tests: qemuxmlconftest: test locking with older virtiofsd
(note the comment that 5/8 test results need to be regenerated, and I
don't have the background knowledge to verify the statement in 6/8 or
understand what's being done with the bitmap in 7/8, but it all passes
the tests, so it's AOK with me :-)
Reviewed-by: Laine Stump <[email protected]>
for the series (with test results regenerated)
and many props/+1's/upboats/etc for adding these tests. It always
bothered me we weren't testing external command commandline generation
for regressions, but never enough to do anything about it.
src/qemu/qemu_passt.c | 38 ++++--
src/qemu/qemu_passt.h | 5 +
src/qemu/qemu_virtiofs.c | 2 +-
src/qemu/qemu_virtiofs.h | 5 +
.../net-user-passt.x86_64-7.2.0.passt0.args | 13 ++
.../net-user-passt.x86_64-latest.passt0.args | 13 ++
...-vhostuser-passt.x86_64-latest.passt0.args | 14 ++
...-vhostuser-passt.x86_64-latest.passt1.args | 5 +
...-vhostuser-passt.x86_64-latest.passt2.args | 6 +
...main-subelements.x86_64-latest.passt0.args | 7 +
...t-user-fs-ccw.s390x-latest.virtiofsd0.args | 3 +
...fs-fd-memory.x86_64-latest.virtiofsd0.args | 9 ++
...fd-openfiles.x86_64-latest.virtiofsd0.args | 10 ++
...fs-hugepages.x86_64-latest.virtiofsd0.args | 3 +
...fs-hugepages.x86_64-latest.virtiofsd1.args | 3 +
.../vhost-user-fs-locking.x86_64-7.2.0.args | 35 +++++
...er-fs-locking.x86_64-7.2.0.virtiofsd0.args | 4 +
.../vhost-user-fs-locking.x86_64-7.2.0.xml | 46 +++++++
.../qemuxmlconfdata/vhost-user-fs-locking.xml | 46 +++++++
...-fs-readonly.x86_64-latest.virtiofsd0.args | 6 +
.../vhost-user-fs-readonly.xml | 1 -
tests/qemuxmlconftest.c | 125 ++++++++++++++++--
tests/testutilsqemu.h | 1 +
23 files changed, 381 insertions(+), 19 deletions(-)
create mode 100644
tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.passt0.args
create mode 100644
tests/qemuxmlconfdata/net-user-passt.x86_64-latest.passt0.args
create mode 100644
tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.passt0.args
create mode 100644
tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.passt1.args
create mode 100644
tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.passt2.args
create mode 100644
tests/qemuxmlconfdata/schema-reorder-domain-subelements.x86_64-latest.passt0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-ccw.s390x-latest.virtiofsd0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-fd-memory.x86_64-latest.virtiofsd0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-fd-openfiles.x86_64-latest.virtiofsd0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-hugepages.x86_64-latest.virtiofsd0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-hugepages.x86_64-latest.virtiofsd1.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-locking.x86_64-7.2.0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-locking.x86_64-7.2.0.virtiofsd0.args
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-locking.x86_64-7.2.0.xml
create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-locking.xml
create mode 100644
tests/qemuxmlconfdata/vhost-user-fs-readonly.x86_64-latest.virtiofsd0.args
