On Thu, Sep 04, 2025 at 16:46:49 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark <[email protected]>
> 
> The legacy probing which reads CPUID registers from QEMU and interprets
> the individual bits is not used with any QEMU version currently
> supported by libvirt.

Preferrably mention also why the statement above is true. In this case 
QEMU_CAPS_CPU_UNAVAILABLE_FEATURES detected by probing the presence of
'unavailable-features' is present on all x86 versions we care about

> Signed-off-by: Jiri Denemark <[email protected]>
> ---
>  src/qemu/qemu_monitor.c                       |  30 ---
>  src/qemu/qemu_monitor.h                       |   5 -
>  src/qemu/qemu_monitor_json.c                  | 191 ------------------
>  src/qemu/qemu_process.c                       |  19 +-
>  .../qemumonitorjson-getcpu-ecx.data           |   7 -
>  .../qemumonitorjson-getcpu-ecx.json           |  57 ------
>  .../qemumonitorjson-getcpu-full.data          |   5 -
>  .../qemumonitorjson-getcpu-full.json          |  46 -----
>  .../qemumonitorjson-getcpu-host.data          |   6 -
>  .../qemumonitorjson-getcpu-host.json          |  45 -----
>  tests/qemumonitorjsontest.c                   | 116 -----------
>  11 files changed, 6 insertions(+), 521 deletions(-)
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-ecx.data
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-ecx.json
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-full.data
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-full.json
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-host.data
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-host.json


Reviewed-by: Peter Krempa <[email protected]>

Reply via email to