On Tue, Nov 25, 2025 at 08:41:11AM +0100, Peter Krempa wrote: > In summary: They are not incorrect, just redundant/misleading/overly > verbose.
Yes, ok, i'll reword that $SUBJECT. > > On Mon, Nov 24, 2025 at 15:09:15 +0000, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé <[email protected]> > > > > The condition > > > > WITH_LINUX_KVM_H && (defined(__linux__) || defined(__FreeBSD__)) > > > > is redundant. If the meson check for linux/kvm.h succeeded, we > > must be on a Linux host and cannot be on a FreeBSD host. Remove > > these redundant OS conditions from the MSR code. > > > > Signed-off-by: Daniel P. Berrangé <[email protected]> > > --- > > src/util/virhostcpu.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > Reviewed-by: Peter Krempa <[email protected]> > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
