On Tue, Nov 25, 2025 at 15:45:33 +0100, Michal Prívozník wrote: > On 11/25/25 14:33, Peter Krempa via Devel wrote: > > From: Peter Krempa <[email protected]> > > > > 'char *tmp' is assigned from calling 'strrchr' on a 'const char *'. New > > clang in fedora doesn't like it. Make 'tmp' const. > > > > Signed-off-by: Peter Krempa <[email protected]> > > --- > > > > https://gitlab.com/MichalPrivoznik/libvirt/-/jobs/12208300313 > > > > src/util/vircgroup.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c > > index 532a7e5690..3d66d3acb2 100644 > > --- a/src/util/vircgroup.c > > +++ b/src/util/vircgroup.c > > @@ -517,7 +517,7 @@ int > > virCgroupSetValueRaw(const char *path, > > const char *value) > > { > > - char *tmp; > > + const char *tmp; > > > > VIR_DEBUG("Set path '%s' to value '%s'", path, value); > > if (virFileWriteStr(path, value, 0) < 0) { > > > NO NO NO. > > There are way too many places that need fixing and this will not help > anything. I have a rawhide VM where I ran the build and this "fixes" > just one place of many. In fact, I think it's CLang that's broken.
Ooh! this is actually 'rawhide'. Thinking this is Fedora 43, I did the above change and it built fine on my box, but I didn't observe the failure locally before as I've just updated. Anyways, I do agree that if this is widespread CLang needs to be fixed or we need a more complete solution.
