Michal Prívozník wrote: > > + > > Guest-specific considerations > > ----------------------------- > > > > Starting from here ... [1] > > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > > index 1467fc7e10..bcb354a9d6 100644 > > --- a/docs/formatdomain.rst > > +++ b/docs/formatdomain.rst > > @@ -3085,6 +3085,11 @@ paravirtualized driver is specified via the ``disk`` > > element. > > the fully-qualified path to the vhost-vdpa character device (e.g. > > ``/dev/vhost-vdpa-0``). > > > > + ``ctl`` > > + Enables the hypervisor to connect to the FreeBSD CAM Target Layer > > (CTL), > > + where CAM is a Common Access Method Storage subsystem. > > + :since:`Since 12.0.0, bhyve`. > > You'll also need to document the 'dev' attribute. > > > + > > With "file", "block", and "volume", one or more optional sub-elements > > ``seclabel`` (See `Security label`_) can be used to override the domain > > security labeling policy for just that source file. > > [1] ... this hunk should go into patch 1/3 where XML parser/formater and > RNG schema is changed. Not only it is semantically closer to that > change, we also like NEWS.rst change to be isolated (lessens chance of a > conflict for eventual backports).
Thanks for review! Yes, I remember about isolating the NEWS.rst changes, but these are drvbhyve.rst, not NEWS.rst. I have moved the formatdomain.rst changes into patch 1/3 with your changes squashed in. I'll send an update for NEWS.rst later this week, there are multiple changes to mention there for bhyve (this one, SLIRP, and arm64 bits). Roman
