On Tue, Jan 06, 2026 at 03:25:18PM +0100, Michal Privoznik via Devel wrote: > From: Michal Privoznik <[email protected]> > > The original commit (v11.9.0-rc1~84) added a dependency checking > of VIR_DOMAIN_HYPERV_STIMER on VIR_DOMAIN_HYPERV_VPINDEX > (meaning, if stimer is on then vpindex must also be on). It > justified this by citing QEMU documentation: > > Per QEMU documentation (docs/system/i386/hyperv.rst): > > ``hv-stimer`` > Enables Hyper-V synthetic timers. <snip/> > > Requires: ``hv-vpindex``, ``hv-synic``, ``hv-time`` > > While the documentation is almost correct (see previous commit > when it's incorrect), the code express no dependency on vpindex > (kvm_hyperv_properties[] array from target/i386/kvm/kvm.c): > > [HYPERV_FEAT_STIMER] = { > .desc = "synthetic timers (hv-stimer)", > .flags = { > {.func = HV_CPUID_FEATURES, .reg = R_EAX, > .bits = HV_SYNTIMERS_AVAILABLE} > }, > .dependencies = BIT(HYPERV_FEAT_SYNIC) | BIT(HYPERV_FEAT_TIME) > }, > > If transitivity is taken into account then the documentation is > of course correct (minus that one aforementioned special case). > Well, there's no need for us to implement transitional checks. > VIR_DOMAIN_HYPERV_STIMER requires VIR_DOMAIN_HYPERV_SYNIC and > whether that requires VIR_DOMAIN_HYPERV_VPINDEX is another > question. > > Just drop the transitive check. > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/837 > Resolves: https://issues.redhat.com/browse/RHEL-138689 > Fixes: da261327ea94300d1aa2d3b76ba9dcd4de6160f6 > Signed-off-by: Michal Privoznik <[email protected]> > --- > src/qemu/qemu_validate.c | 1 - > 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
