On 1/9/26 04:03, Daniel P. Berrangé wrote:
The error_report function can include the program name in any
messages it prints. The qemu_log function has no equivalent
behaviour.
This introduces support for a "program name" in the new
messages API, which will be included by default for all
binaries.
This change tweaks the output of the error_report function,
adding a space between the program name and the location
info. The qemu_log function will gain the program name. This
can be easily seen with the 'log' trace backend, and how it
is now more closely matching error_report output.
Before:
# qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d
'trace:qcrypto*'
qcrypto_tls_creds_x509_load TLS creds x509 load creds=0x5584e13937f0 dir=fish
qcrypto_tls_creds_get_path TLS creds path creds=0x5584e13937f0
filename=ca-cert.pem path=<none>
qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No such
file or directory
After:
# qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d
'trace:qcrypto*'
qemu-system-x86_64: qcrypto_tls_creds_x509_load TLS creds x509 load
creds=0x5584e13937f0 dir=fish
qemu-system-x86_64: qcrypto_tls_creds_get_path TLS creds path creds=0x5584e13937f0
filename=ca-cert.pem path=<none>
qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No such
file or directory
When adding this the '-msg program-name=on|off' option is
introduced, so that the program name (which is enabled by
default) can be supressed if desired. This could be useful
if '-msg guest-name=on' is being used as a more informative
identifier.
Signed-off-by: Daniel P. Berrangé<[email protected]>
---
include/qemu/message.h | 1 +
qemu-options.hx | 9 +++++++--
system/vl.c | 11 ++++++++++-
tests/unit/test-error-report.c | 5 +++--
util/error-report.c | 4 ----
util/message.c | 10 +++++++++-
6 files changed, 30 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <[email protected]>
r~
