Thanks Andreas,
Really appreciate your feedback and suggestions,
I took a look at your revised patch, it looks great,
I have however a question:
+if not get_option('msr_module_load').disabled()
+ if host_machine.system() != 'linux'
+ if get_option('msr_module_load').enabled()
+ error('msr module loading can be enabled on Linux only')
+ endif
+ endif
+ if host_machine.cpu_family() not in [ 'x86', 'x86_64' ]
+ if get_option('msr_module_load').enabled()
+ error('msr module loading can be enabled on x86 only')
+ endif
+ endif
+ conf.set('WITH_MSR_MODULE_LOAD', 1)
+endif
Do we need the second "if get_option('msr_module_load').enabled()" since we
already check it in the outer if ?
