On Thu, Jan 15, 2026 at 03:39:11PM +0100, Michal Privoznik via Devel wrote: > From: Michal Privoznik <[email protected]> > > Some functions inside of domain_logcontext.c call virLogManager > APIs. But that one is available only when remote driver is > enabled. Therefore, make domain_logcontext.c conditional, just > like log_manager.c is: if config.has('WITH_REMOTE'). > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/842 > Signed-off-by: Michal Privoznik <[email protected]> > --- > > v2 of: > > https://lists.libvirt.org/archives/list/[email protected]/thread/7HSM5JB5C7GLBJWXH5A2N2NNAGWXRQFC/ > > diff to v1: > - Instead of #ifdef-ing virLogManager APIs, just make the whole > domain_logcontext.c compiled conditionally. > > src/hypervisor/meson.build | 7 ++++++- > src/libvirt_logging.syms | 7 +++++++ > src/libvirt_private.syms | 7 ------- > 3 files changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
