On 1/16/26 11:16 AM, Ján Tomko via Devel wrote:
On a Thursday in 2026, Laine Stump via Devel wrote:
From: Laine Stump <[email protected]>
Using &newdev->vlan when updating the vlan tag causes problems if the
interface is using a libvirt virtual network to get its vlan tag
info - in this case the info won't be properly pulled from the virtual
network
config, but instead it will just use the (empty)
vlan object from the netdef.
The proper thing to do is to use virDomainNetGetActualVlan(), which
will pull the vlan tag from the network definition, if applicable.
Signed-off-by: Laine Stunp <[email protected]>
Signed-off-by: Laine Stump <[email protected]>
How did you manage to sign off twice? Usually `git commit -s` avoids
this.
That's odd - the duplicate isn't there in my local directory, and I
certainly would have noticed an existing SOB on the adjancent line if I
manually added it in.