On a Monday in 2026, Julio Faracco wrote:
The function virSocketAddrFormatWithPrefix is being used only in
network_nftables.c and network_iptables.c. In both cases, the masked
argument is always true. There is no place where this function is being
called with masked=false since its introduction in commit 426afc00. In
other words, to the current state of libvirt code, we can remove this
argument.

To remove the period after the commit message and the redundant
sentences, I simplified the commit message to:

    Ever since its introduction in commit 426afc00 all the callers
    pass true.

    Remove the argument.


Signed-off-by: Julio Faracco <[email protected]>
---
src/network/network_iptables.c | 10 +++++-----
src/network/network_nftables.c | 10 +++++-----
src/util/virsocketaddr.c       | 14 ++++++--------
src/util/virsocketaddr.h       |  3 +--
4 files changed, 17 insertions(+), 20 deletions(-)


Reviewed-by: Ján Tomko <[email protected]>

Jano

Attachment: signature.asc
Description: PGP signature

Reply via email to