On Wed, Jan 28, 2026 at 10:21:56 -0300, Julio Faracco wrote:
> This commit adds support for virtio-multitouch input devices. It
> introduces the VIR_DOMAIN_INPUT_TYPE_MULTITOUCH type, adds the
> QEMU multitouch capability, updates validation, updates command
> building, and updates security labeling code to handle the new
> device type.
> 
> Signed-off-by: Julio Faracco <[email protected]>
> ---
>  src/conf/domain_audit.c         | 1 +
>  src/conf/domain_conf.c          | 2 ++
>  src/conf/domain_conf.h          | 1 +
>  src/conf/domain_validate.c      | 9 +++++++++
>  src/qemu/qemu_capabilities.c    | 3 +++
>  src/qemu/qemu_capabilities.h    | 1 +
>  src/qemu/qemu_command.c         | 5 +++++
>  src/qemu/qemu_validate.c        | 5 +++++
>  src/security/security_dac.c     | 2 ++
>  src/security/security_selinux.c | 2 ++
>  10 files changed, 31 insertions(+)

Testsuite fails after this patch:

TEST: qemucapabilitiestest
      ....!.!.!.!.!.!...!.!.!...!.!.!.!.!.!.!. 40
      ..!.!.!.!...!.!.!.!...!.......!...!.!.   78  FAIL
28 tests failed. Run them using:
VIR_TEST_DEBUG=1 
VIR_TEST_RANGE=5,7,9,11,13,15,19,21,23,27,29,31,33,35,37,39,43,45,47,49,53,55,57,59,63,71,75,77
 /home/pipo/build/libvirt/gcc/tests/qemucapabilitiestest


You forgot to include the corresponding changes to the detected
capability (by running VIR_TEST_REGENERATE_OUTPUT=1
build/tests/qemucapabilitiestest

For that reason we usually separate the addition of the capability to a
separate patch which must include the test changes.

Reply via email to