On 1/27/26 11:19, Pavel Hrdina via Devel wrote:
> From: Pavel Hrdina <[email protected]>
>
> Signed-off-by: Pavel Hrdina <[email protected]>
> ---
>
> I wonder if we should just drop that argument and use
> QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH inside the function directly
> as the only remaining caller with different value is from virstoragetest.c
That might be also doable, but in a follow up patch.
>
> src/security/virt-aa-helper.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 211c34f926..443646c0a1 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -901,12 +901,12 @@ get_files(vahControl * ctl)
> continue;
> /* XXX - if we knew the qemu user:group here we could send it in
> * so that the open could be re-tried as that user:group.
> - *
> - * The maximum depth is limited to 200 layers similarly to the qemu
> - * implementation.
> */
> - if (!disk->src->backingStore)
> - virStorageSourceGetMetadata(disk->src, -1, -1, 200, false);
> + if (!disk->src->backingStore) {
> + virStorageSourceGetMetadata(disk->src, -1, -1,
> +
> QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH,
> + false);
> + }
>
> /* XXX should handle open errors more careful than just ignoring
> them.
> */
Reviewed-by: Michal Privoznik <[email protected]>
Michal
