On Fri, Jan 30, 2026 at 00:53:38 +0300, Vladimir Sementsov-Ogievskiy wrote: > They are the same as fds and vhostfds, except they accept only > one fd. Let's deprecate redundant options. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > --- > > Hi all! > > after "[PATCH v2 00/12] net: refactoring and fixes" options fd > and vhostfd becomes redundant, fds and vhostfds may be used instead. > > this patch also based on > "[PATCH v6] qapi: net: deprecate vhostforce option", that's why > it's sent separately. > > Based-on: <[email protected]> > Based-on: <[email protected]> > > docs/about/deprecated.rst | 6 ++++++ > qapi/net.json | 9 +++++---- > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index e8ff478583..9010f8ab07 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -451,6 +451,12 @@ TAP ``vhostforce`` (since 11.0) > The ``vhostforce`` option is redundant with the ``vhost`` option. > If they conflict, ``vhost`` takes precedence. Just use ``vhost``. > > +TAP ``fd`` and ``vhostfd`` (since 11.0) > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + > +Use ``fds`` and ``vhostfds`` correspondingly, each set with one fd > +instead of ``fd`` and ``vhsotfd``.
Does this replacement apply/work on all versions supporting vhostfds/fd? I'm asking because libvirt does have code to format the singlular vs plural but none of the versions we support are lacking support for the plural forms so we could replace this unconditionally if it works with older versions.
