On Wed, Feb 18, 2026 at 01:05:26PM +0100, Andrea Bolognani via Devel wrote: > Right now we don't allow any match in that scenario, but really > if a specific type hasn't been requested it means that any type > is considered acceptable and we should allow matching against > both UEFI and BIOS.
AFAICT, there is nothing in the callpath that would limit this to only VMs of a certain architecture or machine. This new codepath only works for architectures which are capable of supporting UEFI and that's only x86, arm (virt machine), riscv (virt machine). For any other arch or machine type we don't want TYPE_NONE to match this way. AFAICS, requiring an explicit "type" attribute for any firmware file matching was part of thue mechanism to avoid impacting back compat for existing XML configurations none of which will have set 'type'. > Signed-off-by: Andrea Bolognani <[email protected]> > --- > src/qemu/qemu_firmware.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c > index 6a074055ca..9f7c981c25 100644 > --- a/src/qemu/qemu_firmware.c > +++ b/src/qemu/qemu_firmware.c > @@ -1104,16 +1104,17 @@ qemuFirmwareMatchDomain(const virDomainDef *def, > * not present, we can still infer this information from > * other factors. Specifically, the pflash loader type is > * only used for UEFI, while the rom loader type can be used > - * both for UEFI and BIOS */ > + * both for UEFI and BIOS. If the loader type has not been > + * specified, we keep our options open */ > switch (loader->type) { > case VIR_DOMAIN_LOADER_TYPE_PFLASH: > wantUEFI = true; > break; > case VIR_DOMAIN_LOADER_TYPE_ROM: > + case VIR_DOMAIN_LOADER_TYPE_NONE: > wantUEFI = true; > wantBIOS = true; > break; > - case VIR_DOMAIN_LOADER_TYPE_NONE: > case VIR_DOMAIN_LOADER_TYPE_LAST: > default: > break; > -- > 2.53.0 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
