On Wed, Feb 18, 2026 at 01:05:31PM +0100, Andrea Bolognani via Devel wrote: > The code is reworked quite significantly, but most of the > existing checks are preserved. Those that aren't, notably the > one that allowed pflash as the only acceptable non-stateless > firmware type, are intentionally removed because they will no > longer reflect reality once support for the uefi-vars QEMU > device is introduced. > > As a side effect, reworking the function in this fashion > resolves a subtle bug: due to the early exits that were being > performed when the loader element was missing, the checks at > the bottom of the function (related to the shim and kernel > elements) were effectively never performed. This is no longer > the case. > > Signed-off-by: Andrea Bolognani <[email protected]> > --- > src/conf/domain_validate.c | 82 +++++++------------ > ...-auto-bios-not-stateless.x86_64-latest.err | 2 +- > ...-auto-bios-not-stateless.x86_64-latest.xml | 35 ++++++++ > ...firmware-auto-bios-nvram.x86_64-latest.err | 2 +- > ...nual-bios-not-stateless.x86_64-latest.args | 32 ++++++++ > ...anual-bios-not-stateless.x86_64-latest.err | 1 - > ...anual-bios-not-stateless.x86_64-latest.xml | 28 +++++++ > ...nual-efi-nvram-stateless.x86_64-latest.err | 2 +- > ...nvram-template-stateless.x86_64-latest.err | 2 +- > ...ware-manual-efi-rw-nvram.x86_64-latest.err | 2 +- > tests/qemuxmlconftest.c | 7 +- > 11 files changed, 135 insertions(+), 60 deletions(-) > create mode 100644 > tests/qemuxmlconfdata/firmware-auto-bios-not-stateless.x86_64-latest.xml > create mode 100644 > tests/qemuxmlconfdata/firmware-manual-bios-not-stateless.x86_64-latest.args > delete mode 100644 > tests/qemuxmlconfdata/firmware-manual-bios-not-stateless.x86_64-latest.err > create mode 100644 > tests/qemuxmlconfdata/firmware-manual-bios-not-stateless.x86_64-latest.xml
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
