On Wed, Feb 18, 2026 at 01:05:46PM +0100, Andrea Bolognani via Devel wrote:
> The element should only be advertised as supported if the QEMU
> binary contains the necessary device and a suitable JSON firmware
> descriptor is found on the system. Right now the latter
> requirement is not satisfied, so it's marked as not supported
> across the board.
> 
> The qemufirmware test is extended to cover the new attribute.
> 
> Signed-off-by: Andrea Bolognani <[email protected]>
> ---
>  src/qemu/qemu_capabilities.c                  | 26 +++++++++++++++-
>  src/qemu/qemu_firmware.c                      |  6 ++++
>  src/qemu/qemu_firmware.h                      |  1 +
>  .../qemu_10.0.0-q35.x86_64+amdsev.xml         |  1 +
>  .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml |  1 +
>  .../qemu_10.0.0-tcg.x86_64+amdsev.xml         |  1 +
>  .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml |  1 +
>  .../qemu_10.0.0-virt.aarch64.xml              |  1 +
>  tests/domaincapsdata/qemu_10.0.0.aarch64.xml  |  1 +
>  tests/domaincapsdata/qemu_10.0.0.ppc64.xml    |  1 +
>  tests/domaincapsdata/qemu_10.0.0.s390x.xml    |  1 +
>  .../qemu_10.0.0.x86_64+amdsev.xml             |  1 +
>  tests/domaincapsdata/qemu_10.0.0.x86_64.xml   |  1 +
>  .../qemu_10.1.0-q35.x86_64+inteltdx.xml       |  1 +
>  .../domaincapsdata/qemu_10.1.0-q35.x86_64.xml |  1 +
>  .../qemu_10.1.0-tcg.x86_64+inteltdx.xml       |  1 +
>  .../domaincapsdata/qemu_10.1.0-tcg.x86_64.xml |  1 +
>  tests/domaincapsdata/qemu_10.1.0.s390x.xml    |  1 +
>  .../qemu_10.1.0.x86_64+inteltdx.xml           |  1 +
>  tests/domaincapsdata/qemu_10.1.0.x86_64.xml   |  1 +
>  .../qemu_10.2.0-q35.x86_64+mshv.xml           |  1 +
>  .../domaincapsdata/qemu_10.2.0-q35.x86_64.xml |  1 +
>  .../qemu_10.2.0-tcg.x86_64+mshv.xml           |  1 +
>  .../domaincapsdata/qemu_10.2.0-tcg.x86_64.xml |  1 +
>  .../qemu_10.2.0-virt.aarch64.xml              |  1 +
>  tests/domaincapsdata/qemu_10.2.0.aarch64.xml  |  1 +
>  .../qemu_10.2.0.x86_64+mshv.xml               |  1 +
>  tests/domaincapsdata/qemu_10.2.0.x86_64.xml   |  1 +
>  .../domaincapsdata/qemu_11.0.0-q35.x86_64.xml |  1 +
>  .../domaincapsdata/qemu_11.0.0-tcg.x86_64.xml |  1 +
>  .../qemu_11.0.0-virt.aarch64.xml              |  1 +
>  tests/domaincapsdata/qemu_11.0.0.aarch64.xml  |  1 +
>  tests/domaincapsdata/qemu_11.0.0.x86_64.xml   |  1 +
>  .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_6.2.0.ppc64.xml     |  1 +
>  tests/domaincapsdata/qemu_6.2.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_7.0.0.ppc64.xml     |  1 +
>  tests/domaincapsdata/qemu_7.0.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_7.1.0.ppc64.xml     |  1 +
>  tests/domaincapsdata/qemu_7.1.0.x86_64.xml    |  1 +
>  .../qemu_7.2.0-hvf.x86_64+hvf.xml             |  1 +
>  .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml  |  1 +
>  .../qemu_7.2.0-tcg.x86_64+hvf.xml             |  1 +
>  .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_7.2.0.ppc.xml       |  1 +
>  tests/domaincapsdata/qemu_7.2.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_8.0.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_8.1.0.s390x.xml     |  1 +
>  tests/domaincapsdata/qemu_8.1.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml  |  1 +
>  .../qemu_8.2.0-tcg-virt.loongarch64.xml       |  1 +
>  .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml  |  1 +
>  .../qemu_8.2.0-virt.aarch64.xml               |  1 +
>  .../qemu_8.2.0-virt.loongarch64.xml           |  1 +
>  tests/domaincapsdata/qemu_8.2.0.aarch64.xml   |  1 +
>  tests/domaincapsdata/qemu_8.2.0.armv7l.xml    |  1 +
>  tests/domaincapsdata/qemu_8.2.0.s390x.xml     |  1 +
>  tests/domaincapsdata/qemu_8.2.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml  |  1 +
>  .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_9.0.0.sparc.xml     |  1 +
>  tests/domaincapsdata/qemu_9.0.0.x86_64.xml    |  1 +
>  .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml  |  1 +
>  .../qemu_9.1.0-tcg-virt.riscv64.xml           |  1 +
>  .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml  |  1 +
>  .../qemu_9.1.0-virt.riscv64.xml               |  1 +
>  tests/domaincapsdata/qemu_9.1.0.s390x.xml     |  1 +
>  tests/domaincapsdata/qemu_9.1.0.x86_64.xml    |  1 +
>  .../qemu_9.2.0-hvf.aarch64+hvf.xml            |  1 +
>  .../qemu_9.2.0-q35.x86_64+amdsev.xml          |  1 +
>  .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml  |  1 +
>  .../qemu_9.2.0-tcg.x86_64+amdsev.xml          |  1 +
>  .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml  |  1 +
>  tests/domaincapsdata/qemu_9.2.0.s390x.xml     |  1 +
>  .../qemu_9.2.0.x86_64+amdsev.xml              |  1 +
>  tests/domaincapsdata/qemu_9.2.0.x86_64.xml    |  1 +
>  tests/qemufirmwaretest.c                      | 31 +++++++++++++------
>  86 files changed, 135 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <[email protected]>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to