On Mon, Mar 23, 2026 at 22:57:15 +0100, Peter Krempa wrote:
> New version to fix offline migration. This time for real. Previously I
> thought I've got the right place, but my migration setup wasn't ready so
> I didn't bother actually testing it. It turns out that the place I've
> fixed before didn't actually trigger the bug due to a lucky scenario.
> 
> Changes to v1:
>  - qemuMigrationSrcBeginXML: Don't call 
> 'qemuMigrationSrcBeginPhaseBlockDirtyBitmaps' with offline VM
> 
>     New patch which actually fixes the bug.
> 
>  - qemuMigrationSrcBeginPhase: Don't call 'qemuBlockNodesEnsureActive' with 
> offline VM
> 
>     Updated commit message now states why 'qemuBlockNodesEnsureActive'
>     doesn't actually cause the same failure due to absence of qemuCaps
>     on an offline VM.
> 
> Peter Krempa (2):
>   qemuMigrationSrcBeginXML: Don't call
>     'qemuMigrationSrcBeginPhaseBlockDirtyBitmaps' with offline VM
>   qemuMigrationSrcBeginPhase: Don't call 'qemuBlockNodesEnsureActive'
>     with offline VM
> 
>  src/qemu/qemu_migration.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Jiri Denemark <[email protected]>

Reply via email to