On Mon, Apr 06, 2026 at 23:29:16 -0400, Laine Stump via Devel wrote: > From: Laine Stump <[email protected]> > > For some reason there were some uses of this struct where "struct > _virLogMetadata" was used instead of just using the typedef > "virLogMetadata" (they are both defined in the same file - > virlog.h). Possibly at one point the struct was in virlog.c and > outsiders could only see it as an opaque object, but even if that was > the case, there are already cases of the typedef being used outside of > virlog.c, and constinuing to use "struct _virLogMetadata" in some > places both looks too much K&R 1st edition and might incorrectly imply > to someone that there *is* data abstraction/hiding going on when there > really isn't. So let's just always use plain virLogMetadata. > > Signed-off-by: Laine Stump <[email protected]> > --- > src/util/virlog.c | 12 ++++++------ > src/util/virlog.h | 4 ++-- > tests/testutils.c | 2 +-
Reviewed-by: Peter Krempa <[email protected]>
