On Sun, Apr 26, 2026 at 18:09:39 +0200, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy <[email protected]>
> ---
>  NEWS.rst | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 478cc6e925..ce9ada942d 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -17,6 +17,27 @@ v12.3.0 (unreleased)
>  
>  * **New features**
>  
> +  * bhyve: Add blkiotune support
> +
> +    The bhyve driver now supports guest I/O throttling configuration::
> +
> +     <blkiotune>
> +       <device>
> +         <path>*</path>
> +         <read_iops_sec>20000</read_iops_sec>
> +         <write_iops_sec>20000</write_iops_sec>
> +         <read_bytes_sec>10000</read_bytes_sec>
> +         <write_bytes_sec>10000</write_bytes_sec>
> +       </device>
> +     </blkiotune>
> +
> +    It uses the ``rctl(4)`` framework to apply these limits.
> +
> +  * bhyve: Implement ``virDomainInterfaceAddresses()`` and 
> ``virDomainGetHostname()``
> +
> +    The bhyve driver now implements the ``virDomainInterfaceAddresses()`` 
> API (``virsh domifaddr``)
> +    and the ``virDomainGetHostname()`` API (``virsh domhostname``).

The first line is a bit long. The explanation paragraph is also
half-redundant with the headline. Consider dropping API names from the
paragraph and perhaps integrate explanation of what the API does in
addition to the virsh usage:

  The bhyve driver now implements APIs allowing to fetch address of
  VM's interfaces (accessible via ``virsh domifaddr`) and the hostname
  of the VM (``virsh domhostname``).

(or s/VM/domain/ in the above)


Reviewed-by: Peter Krempa <[email protected]>

Reply via email to