On Thu, May 14, 2026 at 03:56:49PM +0200, Martin Kletzander via Devel wrote: > From: Martin Kletzander <[email protected]> > > This reverts commit 443c79dd7f7d4051fc0084baaa6c56a55d2aace4. > > Change from VIR_FREE() to g_free meant there is a possible double free > when there is an error during parsing because the parsing it done > directly into the parsedUri member of the esxPrivate, free'd when it > fails and then the caller calls free on it again. Changing back to > VIR_FREE() means there is no double free and no crash. > > Reproducible easily with `virsh -c esx://l?no_verify=2`. > > Signed-off-by: Martin Kletzander <[email protected]> > --- > src/esx/esx_driver.c | 2 +- > src/esx/esx_stream.c | 4 ++-- > src/esx/esx_util.c | 13 +++++++------ > 3 files changed, 10 insertions(+), 9 deletions(-)
Reviewed-by: Pavel Hrdina <[email protected]>
signature.asc
Description: PGP signature
