On Wed, 10 Jun 2026 13:33:46 +0100, Daniel P. Berrangé <[email protected]>
wrote:
> diff --git a/monitor/monitor.c b/monitor/monitor.c
> index a497c25c543..1f1f5fe9fe3 100644
> --- a/monitor/monitor.c
> +++ b/monitor/monitor.c
> @@ -77,10 +77,30 @@ OBJECT_DEFINE_TYPE(Monitor, monitor, MONITOR, OBJECT);
> [ ... skip 14 lines ... ]
> +
> +static void monitor_set_chardev_id(Object *obj, const char *str, Error
> **errp)
> +{
> + Monitor *mon = MONITOR(obj);
> +
> + mon->chardev_id = g_strdup(str);
missing g_free(mon->chardev_id) before.
>
> diff --git a/monitor/qmp.c b/monitor/qmp.c
> index 5231ed506a5..3a4e2ae0e7a 100644
> --- a/monitor/qmp.c
> +++ b/monitor/qmp.c
> @@ -527,7 +527,7 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)
> monitor_list_append(&mon->parent_obj);
> }
>
> -void monitor_new_qmp(Chardev *chr, bool pretty, Error **errp)
> +void monitor_new_qmp(const char *chardev_id, bool pretty, Error **errp)
> {
> MonitorQMP *mon;
> static int counter;
Add ERRP_GUARD(), like monitor_new_hmp()
--
Marc-André Lureau <[email protected]>
