On Thu, Jun 11, 2026 at 01:13:24AM +0400, [email protected] wrote:
> On Wed, 10 Jun 2026 13:34:13 +0100, Daniel P. Berrangé <[email protected]> 
> wrote:
> > diff --git a/tests/functional/generic/test_monitor_hotplug.py 
> > b/tests/functional/generic/test_monitor_hotplug.py
> > index 03087faafc3..f7d72a77c2e 100755
> > --- a/tests/functional/generic/test_monitor_hotplug.py
> > +++ b/tests/functional/generic/test_monitor_hotplug.py
> > @@ -118,6 +124,45 @@ def test_self_removal(self):
> > [ ... skip 30 lines ... ]
> > +        for i in range(10):
> > +            cdevs = [c["label"] for c in self.vm.cmd('query-chardev')]
> > +            if 'hotplug-chr' not in cdevs:
> > +                break
> > +            # Sleep upto 1/2 second to vary the races
> > +            time.sleep(random.random() / 0.5)
> 
> /2 or *0.5

Looking again, this one doesn't need to be random. We just need a
fixed short sleep waiting for the chardev to go away.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to