On Thu, Jul 09, 2026 at 15:00:59 +0200, Radosław Śmigielski via Devel wrote: > From: Radoslaw Smigielski <[email protected]> > > The '--type' option of 'detach-interface' command specifies the > network interface type to detach.
Note that the manpage explicitly mentions only two of the network types but the code as-written supports every type. > > Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 > Signed-off-by: Radoslaw Smigielski <[email protected]> > --- > tools/virsh-domain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index e6f2ca3a449a..79823072ad26 100644 > --- a/tools/virsh-domain.c > +++ b/tools/virsh-domain.c > @@ -12785,6 +12785,7 @@ static const vshCmdOptDef opts_detach_interface[] = { > {.name = "type", > .type = VSH_OT_STRING, > .positional = true, > + .completer = virshDomainNetTypeCompleter, > .help = N_("network interface type") > }, > {.name = "mac", > -- > 2.54.0 > Reviewed-by: Peter Krempa <[email protected]>
